Fix for glue issues when view is updated from outside with $scope.$apply()#45
Open
supersnager wants to merge 3 commits intoLuegg:masterfrom
Open
Fix for glue issues when view is updated from outside with $scope.$apply()#45supersnager wants to merge 3 commits intoLuegg:masterfrom
supersnager wants to merge 3 commits intoLuegg:masterfrom
Conversation
In some circumstances for example when you use $scope.$apply in promises to update view, scrolling not work. This fix use timeout to make shure that every changes in view was made before updating activationState and scrolling
|
Is there any chance for merging in this PR? I am also experiencing the issue, and in case if the PR really solves it, it would be great to see it's changes in a maintenance release! |
Collaborator
|
I see that part of this change is already in master. I cherry-picked the rest of this change onto master, but it will break tests. I would accept a PR that doesn't contain the version number changes and has passing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.